Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix playlunky build github actions #53

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

estebanfer
Copy link
Contributor

The update to conan 2 shouldn't be necessary to make it work after moving back to MSVC 14.39, but it's still nice to have

The old spelunky redist isn't compatible with the one that MSVC 14.40
wants to use. See `mutex` in
https://github.com/microsoft/STL/releases/tag/vs-2022-17.10
@estebanfer
Copy link
Contributor Author

Seems like the CI doesn't pull the latest overlunky??

@estebanfer
Copy link
Contributor Author

ah nice, the lua website is down

@Mr-Auto
Copy link
Contributor

Mr-Auto commented Jun 18, 2024

ah nice, the lua website is down

Maybe we can switch to getting it from github? https://github.com/lua/lua/releases
From what i saw on reddit, the website will be down couple of times in june

@Dregu
Copy link
Contributor

Dregu commented Jun 19, 2024

Maybe we can switch to getting it from github?

I've done that before because they've been down a lot, but they got it back up before I did the switch. IIRC I just added the lua repo as submodule and set(LUA_LOCAL_DIR "lua") and looks like I also left the branch up in case that happens again, how smart of me spelunky-fyi/overlunky@main...Lua

The PR explains why I didn't do it though, had to make changes to sol2, but I'm not that smart with cmake so maybe I didn't?

@estebanfer
Copy link
Contributor Author

My local solution to lua site being down was just adding web archive lua.org as a mirror link to a cmake file in sol2

@Dregu
Copy link
Contributor

Dregu commented Jun 27, 2024

Seems like the CI doesn't pull the latest overlunky??

Yeah so I guess you should update the submodule next and see what happens 🤞🏻

@estebanfer estebanfer marked this pull request as ready for review June 27, 2024 18:20
@Malacath-92 Malacath-92 merged commit f4d4c3f into spelunky-fyi:main Jul 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants